Re: [evolution-patches] Evolution Data Server warnings - all components

[Not Zed <notzed ximian com>]

I've put it in, except for the patch below, which changes the api ever
so slightly.

However, without it, the code probably wont work properly on 64 bit
machines, without other messier changes.

A bunch of places pass &size to a function expecting gsize *, since
gsize/size_t is normally a long, that will not work properly on many
machines and overwrite part of the data pointer.


On Tue, 2005-08-23 at 13:43 +0530, Harish Krishnaswamy wrote:
> Calendar part looks fine to me and I do really want to have this patch
> in as soon as possible.  
> Sush ?

Index: addressbook/ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution-data-server/addressbook/ChangeLog,v
retrieving revision 1.310
diff -u -p -r1.310 ChangeLog
--- addressbook/ChangeLog	24 Aug 2005 02:37:49 -0000	1.310
+++ addressbook/ChangeLog	24 Aug 2005 02:38:20 -0000
@@ -1,3 +1,8 @@
+2005-08-23  Not Zed  <NotZed Ximian com>
+
+	* libebook/e-contact.h (EContactPhoto): use gsize not int for the
+	length.
+
 2005-08-22  Not Zed  <NotZed Ximian com>
 
 	* backends/groupwise/e-book-backend-groupwise.c
Index: addressbook/libebook/e-contact.h
===================================================================
RCS file: /cvs/gnome/evolution-data-server/addressbook/libebook/e-contact.h,v
retrieving revision 1.20
diff -u -p -r1.20 e-contact.h
--- addressbook/libebook/e-contact.h	11 Jul 2005 08:08:04 -0000	1.20
+++ addressbook/libebook/e-contact.h	24 Aug 2005 02:38:20 -0000
@@ -212,7 +212,7 @@ typedef struct {
 } EContactName;
 
 typedef struct {
-	int length;
+	gsize length;
 	char *data;
 } EContactPhoto;