[evolution-patches] Leaks in calendar-file, addresbook-file eplugins (314294)
- From: "Christian Kellner" <Christian Kellner scalix com>
- To: evolution-patches lists ximian com
- Subject: [evolution-patches] Leaks in calendar-file, addresbook-file eplugins (314294)
- Date: Tue, 23 Aug 2005 12:28:49 -0700
Hey all,
spotted some minor leaks. Bug link for overall convenience:
http://bugzilla.gnome.org/show_bug.cgi?id=314294
I will for sure add a ChangeLog including the bug# on commit.
Cheers,
Chrissy
? calendar-file/.calendar-file.c.swp
? addressbook-file/.addressbook-file.c.swp
? addressbook-file/Makefile
? addressbook-file/Makefile.in
? addressbook-file/org-gnome-addressbook-file.eplug
Index: addressbook-file/addressbook-file.c
===================================================================
RCS file: /cvs/gnome/evolution/plugins/addressbook-file/addressbook-file.c,v
retrieving revision 1.2
diff -u -p -r1.2 addressbook-file.c
--- addressbook-file/addressbook-file.c 4 Mar 2005 17:30:24 -0000 1.2
+++ addressbook-file/addressbook-file.c 23 Aug 2005 18:32:54 -0000
@@ -51,14 +51,14 @@ e_book_file_dummy (EPlugin *epl, EConfig
}
relative_uri = e_source_peek_relative_uri (source);
- if (relative_uri && *relative_uri) {
- g_free (uri_text);
-
+ g_free (uri_text);
+
+
+ if (relative_uri && *relative_uri) {
return NULL;
}
e_source_set_relative_uri (source, e_source_peek_uid (source));
- uri_text = e_source_get_uri (source);
return NULL;
}
Index: calendar-file/calendar-file.c
===================================================================
RCS file: /cvs/gnome/evolution/plugins/calendar-file/calendar-file.c,v
retrieving revision 1.2
diff -u -p -r1.2 calendar-file.c
--- calendar-file/calendar-file.c 4 Mar 2005 17:31:58 -0000 1.2
+++ calendar-file/calendar-file.c 23 Aug 2005 18:32:54 -0000
@@ -52,14 +52,13 @@ e_calendar_file_dummy (EPlugin *epl, ECo
}
relative_uri = e_source_peek_relative_uri (source);
- if (relative_uri && *relative_uri) {
- g_free (uri_text);
-
+ g_free (uri_text);
+
+ if (relative_uri && *relative_uri) {
return NULL;
}
e_source_set_relative_uri (source, e_source_peek_uid (source));
- uri_text = e_source_get_uri (source);
return NULL;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]