Re: [evolution-patches] calendar patch for 309420

[Sarfraaz Ahmed <asarfraaz novell com>]

Thank, included the changes and committed.

On Mon, 2005-08-22 at 18:15 +0530, chen wrote:
> On Mon, 2005-08-22 at 16:57 +0530, Sarfraaz Ahmed wrote:
> > if (user_name && host_name && auth_type) {
> > +                       new_uri = g_strdup_printf ("%s%s;%s %s/",
> > base_uri, user_name, auth_type, host_n 
> 
> The checks for user_name and auth_type are redundant. Instead of using
> the uri for getting the host name, we could use relative uri. Do we need
> to get the source name and auth-type again as its already got in
> open_calendar ?

Well, since i already had the esource needed for fetchng the base uri, i
thought i might as well fetch these 2, since its only a hash table
lookup anyway [ and more over this function gets called only once per
calendar at load time ]

-- Sarfraaz