Re: [evolution-patches] Exchange: Fix for the bug 273470

[Sarfraaz Ahmed <asarfraaz novell com>]

Well, its a matter of good programming practise. Also, this class gets
removed when the calendar gets deleted and thats one place when we would
be leaking it. Lets follow the programming style being followed in that
file.

-- Sarfraaz

> Surfy -
> 
> I don't see much difference in terms of a memory usage between having the GMutex object here and having it as a part of the class. In both the cases the object is going to be freed only when the 'evolution-exchange' process is going to terminate. In other words, this object is needed as long as the 'evolution-exchange' process is running. Also I feel it is better to have this object local to the function itself. Also assuming if a lot of threads will need mutex like this, and putting all the mutex objects inside the class is going to make the class bulkier. Please let me know if you still want it to be the part of the class.
> 
> Thanks -
> Praveen.