Re: [evolution-patches] [mail] Patch to close stray fds - bug#307375



On Thu, 2005-08-18 at 12:11 +0800, Not Zed wrote:
> On Wed, 2005-08-17 at 15:04 +0530, Kaushal Kumar wrote:
> > There are some file descriptors which needed to be closed. Attached
> > patch for the same.
> > There was one such case in em-composer-prefs.c which I have corrected
> > in
> > the cvs.
> 
> I can't recall seeing the patch on the mailing list?  Aren't we in patch
> review mode?
I and Harry Lu discussed this with you on IRC yesterday. I thought you
looked at the url_requested function and you were asking us to go ahead
with the change. I misunderstood. Would take care of this in future.
> 
> >  On a second check, three more cases surfaced, so please see if
> > it is okay to commit ?
> > The related bug is #307375.  
> 
> Yep as Jeff said, none of these are necessary.
> 
Okay, then the patch is not needed. Thanks Jeff.

-- 
Kaushal Kumar <kakumar novell com>



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]