Re: [evolution-patches] [addressbook] : Patch for Bug #241219

[Srinivasa Ragavan <sragavan novell com>]

Looks fine except a few.
On Tue, 2005-08-16 at 17:21 +0530, Devashish Sharma wrote:
>  }
>  
> +response (GtkDialog *dialog, int response, EContactEditor *editor)
It should be a static function with void return type.
> +{
> +       char *categories = NULL;
> +       GtkWidget *entry = glade_xml_get_widget(editor->gui,
> "entry-categories");
> +       
> +       if (response == GTK_RESPONSE_OK) {
> +               categories = e_categories_dialog_get_categories
> (E_CATEGORIES_DIALOG (dialog));
> +               if (entry && GTK_IS_ENTRY(entry))
> +                       gtk_entry_set_text (GTK_ENTRY (entry),
> categories);
> +               else
> +                       e_contact_set (editor->contact,
> E_CONTACT_CATEGORIES, categories);
> +       }
> +       gtk_widget_destroy(GTK_WIDGET(dialog));
> +}
> +