Re: [evolution-patches] *Updated* Patch for GTKHTML / A11Y fixes #312189

[Kaushal Kumar <kakumar novell com>]

(Re-sending since it didn't show up on the list)

Hi Mengjie,

Your patch looks fine. 

Since the function is now becoming a public API, you would need to take
approval from release team as we are in API/ABI freeze state. After
approval, please commit.

I assume you have you also tested the other attributes like
strikethrough, underline, rise, etc.	

Thanks,
- Kaushal

On Wed, 2005-08-10 at 16:04 +0800, Mengjie Yu wrote:
> Dear ksh,
> 
> 
> Still remember bug 312189, about the properties of the htmltext ??
> 
> I have checked my patch and found that some properties of the text can not be
> shown. e.g. the color  of the link text, the size and weight of the HEADER text.
> 
> I digged into the code carefully and found we could use prepare_attrs to get the
> PangoAttrList which contains the full pango information. The pango information
> getting directly from the PangoAttrList of htmltext structure is not sufficient
> enough actually.
> 
> So I made a new patch again.
> 
> the related URL is:
> http://bugzilla.gnome.org/show_bug.cgi?id=312189
> The patch for this bug is also available on the above URL.
> 
> Will you please help me to review it when you are not busy?
> 
> Thanks a lot.
> 
> Yours,
> Mengjie
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches
-- 
Kaushal Kumar <kakumar novell com>