Re: [evolution-patches] Mailer : Patch for bug#311719 (UI)

[Not Zed <notzed ximian com>]

On Fri, 2005-08-12 at 00:03 +0530, Antony Vincent Pandian wrote:
>         EM_POPUP_SELECT_ADD_SENDER         = 1<<14,
>         EM_POPUP_SELECT_FOLDER             = 1<<15,     /* do we have
> any folder at all? */
>         EM_POPUP_SELECT_LAST               = 1<<17,     /* reserve 2
> slots */
> +       EM_POPUP_SELECT_JUNK               = 1<<18,
> +       EM_POPUP_SELECT_NOT_JUNK           = 1<<19,
>  };

Wrong spot! Can't you read the _LAST bit ...

>  
>  /**
> --- /home/evolution/Antony/junk_disable_bug/em-popup.c  2005-08-10
> 18:37:12.000000000 +0530
> +++ em-popup.c  2005-08-11 23:51:58.576898696 +0530
> @@ -229,6 +229,11 @@ em_popup_target_new_select(EMPopup *emp,
>                 else
>                         mask &= ~EM_POPUP_SELECT_MARK_IMPORTANT;
>  
> +               if (flags & CAMEL_MESSAGE_JUNK)
> +                       mask &= ~EM_POPUP_SELECT_NOT_JUNK;
> +               else if ((flags & CAMEL_MESSAGE_DELETED) !=
> CAMEL_MESSAGE_DELETED)
> +                       mask &= ~EM_POPUP_SELECT_JUNK; 

This isn't a test for not-junk, its a test for not deleted.


Anyway you missed all the hook-loading stuff.  As i said grep for
deleted case-insensitively in em-popup.c, there are other instances you
need to "copy".


-- 
adfa(evolution-2.4:20087): gtkhtml-WARNING **: cannot find icon:
'stock_insert-url' in gnome