[evolution-patches] Re: [Fwd: Exchange: Fix for bug 273272]

[Sarfraaz Ahmed <asarfraaz novell com>]

Hi,

[Looks like this one also missed the patches list. ]

Looks good, please make the changes mentioned below and commit.

On Tue, 2005-08-16 at 15:57 +0530, Praveen Kumar wrote:
>         Hello -

>         
>         
>         
>         
>         
>         
>         differences
>         between files
>         attachment
>         (bug-273272-evo.patch)
>         


>         Index: plugins/exchange-operations/exchange-config-listener.c
>         ===================================================================

>         @@ -299,42 +304,45 @@ add_account_esources (ExchangeAccount *a
>                                 e_source_group_add_source 

>         +/*
>         GCONF_VALUE_STRING, ids, NULL); */
>         +/*                     g_slist_foreach (ids, (GFunc) g_free,
>         NULL); */
>         +/*                     g_slist_free (ids); */

If this is intended to be used later ... then put a comment as to what
case that would be .. and mark this code under an #if 0 .. #endif code.

>                                 g_object_unref (source);

>         ids, NULL); */
>         +/*                     g_slist_foreach (ids, (GFunc) g_free,
>         NULL); */
>         +/*                     g_slist_free (ids); */

Similar

>                                 g_object_unref (source);

>         +static void 
>         +remove_selected_non_offline_esources (ExchangeAccount
>         *account)

We could split this into a single function that just removes the
esources for a single component and then call it twice.

>         +{
>         +       ESourceGroup *group;

>         e_source_get_property (source,
>         +
>         "offline_sync");
>         +                                       while (1) {
>         +
>         +                                               node_to_be_deleted = 
>         +                                                       g_slist_find_custom (ids, 
>         +
>         source_uid, 
>         +
>         (GCompareFunc) strcmp);

As we discussed, we could loop on the node_to_be_deleted variable.

>         +                                               if (!
>         node_to_be_deleted) {

Thanks
-- Sarfraaz