Re: [evolution-patches] Re: patch to fix #313514 (GAL)



Hi Li,

>  
> -       if (notify)
> -               g_signal_emit_by_name (a11y,
> -                               "active-descendant-changed",
> -                               cell);
> +       if (notify) 
> +               atk_focus_tracker_notify (cell);
> 
just some thoughts..

- Could it be like, 
if (notify && cell && ATK_IS_OBJECT (cell)) 
	...

- Should we doing gal_a11y_e_cell_add_state(cell, ATK_STATE_FOCUSED,
FALSE); 
This query is because a similar scenario is being handled in a patch at
http://lists.ximian.com/pipermail/evolution-patches/2004-March/004890.html
If it is the right thing to do, we could use it.

Other than that, I feel the patch is okay.

Thanks,
Kaushal



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]