Re: [evolution-patches] Exchange, calendar fixes deletion, decline problem

[Sarfraaz Ahmed <asarfraaz novell com>]

A few changes needed.

On Fri, 2005-08-12 at 18:18 +0530, Arunprakash wrote:
> Hi,

> 
> 
> 
> 
> 
> 
> differences
> between files
> attachment
> (exchange-fixes-deletion-declined.patch)
> 

> Index: calendar/e-cal-backend-exchange-calendar.c
> ===================================================================


>  
> +static gchar *
> +get_cal_owner_email (ECalBackendSync *backend)

This should move to e-cal-backend-exchange.c with a proper function name
like e_cal_backend_exchange_get_ ....

> +{
> +       ECalBackendExchange *cbex = E_CAL_BACKEND_EXCHANGE (backend);


> +/* stolen from e-itip-control.c with some modifications */
> +static icalproperty *
> +find_attendee (icalcomponent *ical_comp, const char *address)

how about calling this find_attendee_prop ?

> +{
> +       icalproperty *prop;

> +
> +static gboolean
> +check_owner_partstatus_for_declined (ECalBackendSync *backend,
> +                                    icalcomponent *icalcomp)
> +{
> +       icalproperty *icalprop;
> +       icalparameter *param;
> +       gchar *email;
> +       
> +       g_return_val_if_fail (E_IS_CAL_BACKEND (backend), FALSE);
> +       g_return_val_if_fail (icalcomp != NULL, FALSE);

These checks are redundant.

> +       
> +       email = get_cal_owner_email (backend);

>  static ECalBackendSyncStatus
>  create_object (ECalBackendSync *backend, EDataCal *cal,
>                char **calobj, char **uid)
> @@ -1195,6 +1264,9 @@ remove_object (ECalBackendSync *backend,
>         struct icaltimetype time_rid;
>         ECalBackendSyncStatus ebs_status;
>         
> +       /* Will handle only deleting singe instance and all instances
> of
> +          recurring appointments and meetings and non-recurring. */

Instead list down the items we are handling in a bulleted order and
mention the list of items we do not handle.

> +       
>         cbexc = E_CAL_BACKEND_EXCHANGE_CALENDAR (backend);
>  


> calobj, mod, &obj, NULL);
> -                       if (ebs_status !=
> GNOME_Evolution_Calendar_Success)
> -                               goto error;
> -                       
> -                       g_free (obj);
> -                       return ebs_status;
> +               g_free (obj);

unref the comp here ...

> +               return ebs_status;
> +       }
> +


> +               }
>         }
> +       *object = NULL;

unref the comp here too.

>  


> @@ -1634,7 +1712,7 @@ send_objects (ECalBackendSync *backend, 
>                 tzcomp = icalcomponent_get_next_component (top_level,
> 
> ICAL_VTIMEZONE_COMPONENT);
>         }
> -                                                                                                

There seems to be some blank line here.

> +


Please send a new patch with these changes.

Thanks
-- Sarfraaz