Re: [evolution-patches] Exchange: Fix for bugs 272784 and 220168

[Sarfraaz Ahmed <asarfraaz novell com>]

Looks good. There are a few minor changes needed.

> 
> 
> 
> 
> 
> 
> differences
> between files
> attachment
> (evolution-exchange-account-config.patch)

There are a few warnings in evolution-exchange with this patch. Please
remove them before committing.

> 
> 
> 
> 
> 
> 
> differences
> between files
> attachment
> (evolution-plugin-exchange-account-config.patch)
> 


> Index: plugins/exchange-operations/exchange-config-listener.c
> ===================================================================

> +
> +/**
> + * exchange_modify_esource_group_name
> + * 
> + * @old_name: Old name of the ESourceGroup
> + * @new_name: New name of the ESourceGroup
> + *
> + * This function modifies the old source group name to the specified
> new
> + * source group name
> + **/ 
> +static void
> +exchange_modify_esource_group_name (const char *old_name, const char
> *new_name)

Make this as a member function of config_listener so we can use the
gconf client directly from it.

> +{
> +       GConfClient *client;


> +       for ( ; groups != NULL; groups = g_slist_next (groups)) {
> +               group = E_SOURCE_GROUP (groups->data);
> +               if (!strcmp (e_source_group_peek_name (group),
> old_name)) {

Make sure that a NULL value from peek_name is handled.

> +                       e_source_group_set_name (group, new_name);
> +                       break;


-- Sarfraaz