Re: [evolution-patches] Exchange: patch for bug #257802

[Sarfraaz Ahmed <asarfraaz novell com>]

Thanks, looks good. 2 minor changes are needed though. Please
incorporate those changes and commit.


> +       GList *new_list;
> +
> +       new_list = e_contact_get (new_contact, prop_mapping->field);
> +       while (new_list) {
> +               if (prop_mapping->field == E_CONTACT_IM_MSN) {
> +                       e2k_properties_set_string (props, 
> +
> E2K_PR_OUTLOOK_CONTACT_IM_ADDR,
> +                                                  g_strdup
> (new_list->data));

We can break from the loop here once we find the MSN field. Unless,
Exchange supports more than one MSN im id, per contact.

> +               }
> +               new_list = g_list_next (new_list);
> +       }
> +}
> +
> +static void
> +populate_im (EContactField field, EContact *new_contact, void *data)
> +{
> +       GList *im_attr_list = NULL;
> +       EVCardAttribute *attr;
> +
> +       if (field == E_CONTACT_IM_MSN) {
> +               attr = e_vcard_attribute_new ("",
> e_contact_vcard_attribute (field));
> +               e_vcard_attribute_add_param_with_value (attr,
> e_vcard_attribute_param_new (EVC_TYPE), "WORK");

Split the above 2 lines so that each does not exceed more than 80
characters.

> +
> +               e_vcard_attribute_add_value (attr, (const char
> *)data);


P.S : Please remove the previous mail contents while replying. 

-- Sarfraaz