Re: [evolution-patches] patch to fix disabled "Next" (Mail)



looks good thanks!

On Fri, 2005-08-12 at 01:36 -0600, Jain Vivek wrote:
> hi,
> 
> Here is the updated patch.
> Just moved 'prepare' part up before we validate it. So that we do not
> have to explicitly set it as TRUE, and ensures that it works in all the
> cases.
> 
> Thanks,
> Vivek Jain
> On Fri, 2005-08-12 at 04:27 +0000, Vivek Jain  wrote:
> > hi,
> > 
> > The attached patch fixes the ugly bug of "Next" not getting enabled on
> > Account Management page while creating an account.
> > 
> > The problem I found was:
> > First time when check_complete is called the page is incomplete so 'ok'
> > is FALSE. In the same code flow (1), we prepare the page and set the
> > default entry in the entry box. This in turn calls another
> > check_complete which returns status ok 'TRUE' and the 'next' gets
> > enabled.
> > But finally (1) returns the old 'ok' status which was FALSE and the
> > button is again disabled.
> > 
> > The fix just makes sure that after we have prepared the management page
> > (have put the proper entry) we consider that as complete, which is TRUE,
> > and have 'ok' as TRUE.
> > 
> > Thanks,
> > Vivek Jain
> > 
> > PS: I still have to find the bug number for it.
> > 
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches
-- 
adfa(evolution-2.4:20087): gtkhtml-WARNING **: cannot find icon:
'stock_insert-url' in gnome 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]