[evolution-patches] patch to fix disabled "Next" (Mail)



hi,

The attached patch fixes the ugly bug of "Next" not getting enabled on
Account Management page while creating an account.

The problem I found was:
First time when check_complete is called the page is incomplete so 'ok'
is FALSE. In the same code flow (1), we prepare the page and set the
default entry in the entry box. This in turn calls another
check_complete which returns status ok 'TRUE' and the 'next' gets
enabled.
But finally (1) returns the old 'ok' status which was FALSE and the
button is again disabled.

The fix just makes sure that after we have prepared the management page
(have put the proper entry) we consider that as complete, which is TRUE,
and have 'ok' as TRUE.

Thanks,
Vivek Jain

PS: I still have to find the bug number for it.

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/mail/ChangeLog,v
retrieving revision 1.3690
diff -u -p -r1.3690 ChangeLog
--- ChangeLog	11 Aug 2005 06:11:04 -0000	1.3690
+++ ChangeLog	12 Aug 2005 04:25:22 -0000
@@ -1,3 +1,8 @@
+2005-08-12  Vivek Jain <jvivek novell com>
+
+	* em-account-editor.c : (emae_check_complete)
+	set ok to TRUE after preparing management page
+
 2005-08-11  Vivek Jain <jvivek novell com>
 	
 	* em-folder-tree-model.c: (account_changed)
Index: em-account-editor.c
===================================================================
RCS file: /cvs/gnome/evolution/mail/em-account-editor.c,v
retrieving revision 1.33
diff -u -p -r1.33 em-account-editor.c
--- em-account-editor.c	8 Aug 2005 09:02:25 -0000	1.33
+++ em-account-editor.c	12 Aug 2005 04:25:22 -0000
@@ -2410,7 +2410,7 @@ static gboolean
 emae_check_complete(EConfig *ec, const char *pageid, void *data)
 {
 	EMAccountEditor *emae = data;
-	int ok = TRUE;
+	gboolean ok = TRUE;
 	const char *tmp;
 	EAccount *ea;
 
@@ -2496,6 +2496,9 @@ emae_check_complete(EConfig *ec, const c
 					sprintf(template + len, " (%d)", i++);
 
 				gtk_entry_set_text(emae->priv->identity_entries[0], template);
+				
+				/*we have prepared the page so in this case its complete*/
+				ok = TRUE;
 			}
 		}
 	}


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]