[evolution-patches] [GW Proxy Plugin] Crash fix



Hi,

Attached patch fixes a crash in GW Proxy plugin.

The Changelog explains it all.

Thanks,

V. Varadhan.
Index: plugins/groupwise-features/ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/plugins/groupwise-features/ChangeLog,v
retrieving revision 1.26
diff -u -p -r1.26 ChangeLog
--- plugins/groupwise-features/ChangeLog	10 Aug 2005 07:15:25 -0000	1.26
+++ plugins/groupwise-features/ChangeLog	11 Aug 2005 13:36:08 -0000
@@ -1,3 +1,8 @@
+2005-08-11  Sankar P  <psankar novell com>
+
+	* proxy.c:
+	(proxy_commit) : Check "prd" for NULL, ALWAYS.
+	
 2005-08-10  Sankar P  <psankar novell com>
 
 	* proxy.c :  
Index: plugins/groupwise-features/proxy.c
===================================================================
RCS file: /cvs/gnome/evolution/plugins/groupwise-features/proxy.c,v
retrieving revision 1.5
diff -u -p -r1.5 proxy.c
--- plugins/groupwise-features/proxy.c	10 Aug 2005 07:15:25 -0000	1.5
+++ plugins/groupwise-features/proxy.c	11 Aug 2005 13:37:47 -0000
@@ -537,10 +537,13 @@ proxy_commit (GtkWidget *button, EConfig
 	target_account = (EMConfigTargetAccount *)data->config->target;
 	account = target_account->account;
 	prd = g_object_get_data ((GObject *)account, "prd");    
+
+	/* In case of non-GroupWise preferences edit, "prd" will be NULL. */
+	if (!prd || !prd->priv || !prd->priv->proxy_list)
+		return;
+
 	priv = prd->priv;
 	list_iter = priv->proxy_list;
-	if (prd == NULL || list_iter == NULL)
-		return;
 	for (;list_iter; list_iter = g_list_next (list_iter)) {
 		aclInstance = (proxyHandler *) list_iter->data;
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]