[evolution-patches] [addressbook]Bug in comparing email addresses



Hi,

 The function match_email_hostname was never returning true and the
comparison was also not proper. 
this patch fixes the bug.

Thanks
devashish 
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/addressbook/ChangeLog,v
retrieving revision 1.1975
diff -u -p -r1.1975 ChangeLog
--- ChangeLog	9 Aug 2005 22:40:59 -0000	1.1975
+++ ChangeLog	11 Aug 2005 09:21:57 -0000
@@ -1,3 +1,9 @@
+2005-08-11  Devashish Sharma <sdevashish novell com>
+
+	* gui/widgets/eab-contact-compare.c (match_email_hostname): This
+	function was never returning true and the comparison was also not
+	proper.Fixed 
+
 2005-08-10  Tor Lillqvist  <tml novell com>
 
 	* importers/Makefile.am: Use privsolib instead of privlib (no
Index: eab-contact-compare.c
===================================================================
RCS file: /cvs/gnome/evolution/addressbook/gui/merging/eab-contact-compare.c,v
retrieving revision 1.8
diff -u -p -r1.8 eab-contact-compare.c
--- eab-contact-compare.c	29 Sep 2004 19:20:11 -0000	1.8
+++ eab-contact-compare.c	11 Aug 2005 09:25:00 -0000
@@ -459,9 +459,10 @@ match_email_hostname (const gchar *addr1
 		--addr1;
 		--addr2;
 	}
-
-	/* This will match bob foo ximian com and bob ximian com */
-	return *addr1 == '.' || *addr2 == '.';
+	if((*addr1 == '@' && *addr2 != '@' ) || (*addr2 == '@' && *addr1 != '@'))
+	       return FALSE;	
+	
+	return TRUE;
 }
 
 static EABContactMatchType


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]