Re: [evolution-patches] 271985, mail related debug output



On Wed, 2005-08-10 at 11:26 -0400, Jeffrey Stedfast wrote:
> I guess my only possible objection to the patch is should
> account->[source,transport]->url's ever be allowed to be an empty
> string?
> 
> Presumably this happens for "None" account types?

Yes.  I dont think transport can be empty but i didn't think it was
worth worrying about.

> Just wondering if EAccount should change url to be NULL rather than
> allow them to be ""

No.  The get accessor api explictly only ever returns valid strings, to
avoid null dereferences.  The code shouldn't be peeking the content
anyway.

> Jeff
> 
> On Wed, 2005-08-10 at 11:18 +0800, Not Zed wrote:
> > patch on:
> > http://bugzilla.gnome.org/show_bug.cgi?id=271985
> > 
> > fixes some mail-related debug/unecessary warning output
> > 
-- 
adfa(evolution-2.4:20087): gtkhtml-WARNING **: cannot find icon:
'stock_insert-url' in gnome 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]