Re: [evolution-patches] Plugins - GroupWise Proxy

[Shreyas <sshreyas novell com>]

Hey,

It would be nice if you could remove all the commented out crud code and
also name a few of the GList iters in a better fashion than just calling
them 'p'. Also in org_gnome_proxy you could directly use
priv->proxy_list instead of having a local proxy_list, ofcourse it does
not make any radical difference but just follows how the rest of the
code is written,

Other than those minor niggles the rest looks good to go :-)

Thanks,
Shreyas
On Mon, 2005-08-08 at 12:44 +0530, Sankarasivasubramanian P wrote:
> Hi,
> 
> Attached with is the patch to move the GList to maintain proxies-list
> into the proxyDialog structure, rather than setting an amorphous GList
> on EAccount using g_object_set.  This fixes #312352 also.
> 
> Please review,
> 
> Thanks,
> Sankar
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches