Re: [evolution-patches] fix-309499

[Harish Krishnaswamy <kharish novell com>]

You have missed out the leak on the attendee list. Also, you can compute
if the list was modified, without having to use a variable (again, I'd
prefer gboolean to a custom enum, if you must).

Harish
On Fri, 2005-08-05 at 12:34 +0530, P. S. Chakravarthi wrote:
> hi
> 
> sending the revised patch ..
> please review.
> 
> regards.
> 
> On Fri, 2005-08-05 at 11:49 +0530, Harish Krishnaswamy wrote:
> > >                                 continue;               
> > >  
> > You must be checking for 'delegate' here.                       
> > > +                       if(attendee->delfrom && *attendee->delfrom)
> > > +                               attendee->delfrom = "";
> > > +       
> > >                         recipient = g_new0 (EGwItemRecipient, 1);
> > >  
> > >                         /* len (MAILTO:) + 1 = 7 */
> > > @@ -375,6 +378,9 @@ set_attendees_to_item (EGwItem *item, EC
> > >                         recipient_list = g_slist_append
> > > (recipient_list, recipient);
> > >                 }
> > >  
> > The attendee list needs to be set only if it had been modified.
> > So check if you had modified it first.
> > > +               /* Reset the ECalComponent with changes */
> > > +               e_cal_component_set_attendee_list (comp,
> > > attendee_list);        
> > > +       
> > >                 e_gw_item_set_recipient_list (item, recipient_list);
> > The attendee list should be freed using the
> > e_cal_component_free_attendee_list function.
> > 
> > 
> > Kindly submit the patch again with the suggested changes.
> > 
> > Harish
> > 
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches