[evolution-patches] Addressbook - wrong error message



Hi,

For the LDAP address book, while creating a contact with invalid DN,
we get the error "Contact not found".
Using "Other error" instead of this.

Please review.
Sushma.
Index: addressbook/ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution-data-server/addressbook/ChangeLog,v
retrieving revision 1.300
diff -u -p -r1.300 ChangeLog
--- addressbook/ChangeLog	2 Aug 2005 07:17:22 -0000	1.300
+++ addressbook/ChangeLog	3 Aug 2005 10:40:55 -0000
@@ -1,3 +1,9 @@
+2005-08-03  Sushma Rai  <rsushma novell com>
+
+	* backends/ldap/e-book-backend-ldap.c (ldap_error_to_response):
+	Handling LDAP_INVALID_DN_SYNTAX error code, so that we don't get the
+	misleading error message "conect not found".
+
 2005-08-02  Sushma Rai  <rsushma novell com>
 
 	* backends/groupwise/e-book-backend-groupwise.c 
Index: addressbook/backends/ldap/e-book-backend-ldap.c
===================================================================
RCS file: /cvs/gnome/evolution-data-server/addressbook/backends/ldap/e-book-backend-ldap.c,v
retrieving revision 1.45
diff -u -p -r1.45 e-book-backend-ldap.c
--- addressbook/backends/ldap/e-book-backend-ldap.c	27 Jul 2005 09:15:07 -0000	1.45
+++ addressbook/backends/ldap/e-book-backend-ldap.c	3 Aug 2005 10:41:58 -0000
@@ -934,6 +934,8 @@ ldap_error_to_response (int ldap_error)
 {
 	if (ldap_error == LDAP_SUCCESS)
 		return GNOME_Evolution_Addressbook_Success;
+	else if (ldap_error == LDAP_INVALID_DN_SYNTAX)
+		return GNOME_Evolution_Addressbook_OtherError;
 	else if (LDAP_NAME_ERROR (ldap_error))
 		return GNOME_Evolution_Addressbook_ContactNotFound;
 	else if (ldap_error == LDAP_INSUFFICIENT_ACCESS)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]