Re: [evolution-patches] *New* Patch for GTKHTML / A11Y fixes #312189

[Kaushal Kumar <kakumar novell com>]

Hi Mengjie,

Now, that we have get_run_attributes implemented, we can remove the
earlier declaration (commented out) of the same in text.c. Could you
also  remove those for get_offset_at_point and get_character_extents
since they too are implemented already.

> +static AtkAttributeSet * html_a11y_text_get_run_attributes (AtkText
> *text, gint offset, gint *start_offset, gint *end_offset);
> 
could we please follow the column limit of 80 (by wrapping down the
parameter list). if possible, could you modify in the other places in
the patch too.  

> +               attrib_set = html_a11y_text_add_attribute

Since html_a11y_text_add_attribute is same as gail_misc_add_attribute,
could we not use gail_misc_add_attribute directly. It is already
available since text.h includes gail-util.h which has gailmisc.h.
This way we would be independent of the changes that are made to the
standard gail api.

>  (attrib_set, 
> +                                       ATK_TEXT_ATTR_BG_COLOR, 
> +                                       value);
> +       } 
> +

I think we need to free value here, else it would get leaked.
 
> +       pango_attr_iterator_destroy (iter);
> +       return attrib_set;
> +
> +}
> 
> 
Rest looks fine.
Thanks for your work.

Cheers,
Kaushal