Re: [evolution-patches] Exchange: Patch for bug #311324

[Sarfraaz Ahmed <asarfraaz novell com>]

Thanks. This looks good now :-). Please correct a few minor changes and
commit it.


> Index: exchange-config-listener.c
> ===================================================================

> +ExchangeConfigListenerStatus
> +exchange_config_listener_get_offline_status (ExchangeConfigListener 

> +
> +       g_return_if_fail (excl);
> +
> +       if (!excl)
> +               return CONFIG_LISTENER_STATUS_NOT_FOUND; 

This is not correct. You should probably have this as ... 

	g_return_val_if_fail (excl != NULL, CONFIG_LISTENER_STATUS_NOT_FOUND );

> +       
> +       priv = excl->priv;

> Index: exchange-folder.c
> ===================================================================

> @@ -305,12 +305,29 @@ org_gnome_exchange_folder_ab_unsubscribe
>         gchar *title = NULL;

> +       if (status != CONFIG_LISTENER_STATUS_OK) {
> +               g_warning ("Exchange account is not created");

Probably change this warning to something else as well.

> +               return;

Thanks
-- Sarfraaz