Re: [evolution-patches] (Mailer) Fix for attachment bar to hide the labels when No attachments

[Not Zed <notzed ximian com>]

Shouldn't you hide the whole thing?  why track the label widget
separately?  i.e. the vbox containing everything, not just the label
widget box.

remember that changing the string affects all of the translators ... is
it that important?

I dont think you need to change all of this, it would be better to keep
the ngettext version rather than have 2 separate 'n attachment' strings.

+       /* We come here only when there are attachments */
        nattachments = e_attachment_bar_get_num_attachments
(E_ATTACHMENT_BAR(efhd->priv->attachment_bar));
-       if (nattachments) {
+       if (nattachments > 1) {
                char *txt;
 
-               /* Cant i put in the number of attachments here ?*/
-               txt = g_strdup_printf(ngettext("%d Attachment", "%d
Attachments", nattachments), nattachments);
+               txt = g_strdup_printf("%d attachments", nattachments);
                gtk_label_set_text ((GtkLabel *)efhd->priv->label, txt);
                g_free (txt);
 
-               /* Enable the expander button and the save all button.*/
-               gtk_widget_set_sensitive (efhd->priv->arrow, TRUE);
-               gtk_widget_set_sensitive (efhd->priv->save, TRUE);
+       } else {
+               /* Show the expander button and the save all button.*/
+               gtk_widget_show (efhd->priv->label_box);
        }

On Tue, 2005-08-02 at 10:58 +0530, Srinivasa Ragavan wrote:
> Hi,
> 
> I have fixed few issues wrt the new attachment bar. 
>  (1) It hides the label/expander when no attachments are there. 
> also it changes Attachments to attachments. 
> 
> -Srini
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches