[evolution-patches] Patch for GroupWise URL Comparison



Hi,

When comparing two CamelURLs in the groupwise provider, there was no
checking for the protocol. The attached patch fixes this and hence fixes
#312185.

Please review it.

Thanks,
Sankar
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution-data-server/camel/providers/groupwise/ChangeLog,v
retrieving revision 1.75
diff -u -p -r1.75 ChangeLog
--- ChangeLog	30 Jul 2005 19:05:02 -0000	1.75
+++ ChangeLog	1 Aug 2005 10:05:20 -0000
@@ -1,3 +1,9 @@
+2005-08-01  Sankar P  <psankar novell com>
+	
+	* camel-groupwise-provider.c: (groupwise_url_equal) 
+	Added code to check the protocol while comparing two URLs.
+	Fixes bug #312185
+	
 2005-07-30  Parthasarathi Susarla <sparthasarathi novell com>
 	
 	* camel-groupwise-store.c:
Index: camel-groupwise-provider.c
===================================================================
RCS file: /cvs/gnome/evolution-data-server/camel/providers/groupwise/camel-groupwise-provider.c,v
retrieving revision 1.29
diff -u -p -r1.29 camel-groupwise-provider.c
--- camel-groupwise-provider.c	24 Jul 2005 05:47:03 -0000	1.29
+++ camel-groupwise-provider.c	1 Aug 2005 10:05:20 -0000
@@ -188,7 +188,8 @@ groupwise_url_equal (gconstpointer a, gc
 {
 	const CamelURL *u1 = a, *u2 = b;
 	
-	return check_equal (u1->user, u2->user)
+	return check_equal (u1->protocol, u2->protocol)
+		&& check_equal (u1->user, u2->user)
 		&& check_equal (u1->authmech, u2->authmech)
 		&& check_equal (u1->host, u2->host)
 		&& u1->port == u2->port;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]