[evolution-patches] *NEW* Patch for #302275



Dear hpj,

Here is the patch for #302275. Actually, One of my patches committed last week results in this bug.
 
the related URL is:
http://bugzilla.gnome.org/show_bug.cgi?id=302275
The patch for this bug is also available on the above URL.

It is about gal part.

Will you please help me to review it?

Thanks a lot.

Yours,
Mengjie

? 1
? gal-2.6.pc
? gal-300954-updated.diff
? gal-300954.diff
? gal-302275.diff
? gal-73207.diff
? gal-74434.diff
? gal.pc
? docs/gal-api.html
? gal/widgets/adjustment.diff
? gal/widgets/e-reflow.c.bak_414
? gal/widgets/mypatch.diff
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/gal/ChangeLog,v
retrieving revision 1.928
diff -u -p -r1.928 ChangeLog
--- ChangeLog	28 Apr 2005 08:09:53 -0000	1.928
+++ ChangeLog	28 Apr 2005 10:40:14 -0000
@@ -1,3 +1,10 @@
+2005-04-28  Mengjie Yu  <meng-jie yu sun com>
+
+	* gal/widgets/e-reflow.c: (do_adjustment):
+	we should not do any layout adjustment if the item doesn't exist.
+
+	Fixes #302275
+
 2005-04-28  Li Yuan  <li yuan sun com>
 
 	* gal/widgets/e-canvas-background.c: (ecb_style_set),
Index: gal/widgets/e-reflow.c
===================================================================
RCS file: /cvs/gnome/gal/gal/widgets/e-reflow.c,v
retrieving revision 1.57
diff -u -p -r1.57 e-reflow.c
--- gal/widgets/e-reflow.c	22 Apr 2005 08:04:03 -0000	1.57
+++ gal/widgets/e-reflow.c	28 Apr 2005 10:40:19 -0000
@@ -168,8 +168,11 @@ do_adjustment (gpointer user_data)
 	gfloat value, min_value, max_value;
 	EReflow *reflow = user_data;
 
-	adj = gtk_layout_get_hadjustment (GTK_LAYOUT (GNOME_CANVAS_ITEM (reflow)->canvas));
 	row = reflow->cursor_row;
+	if (row == -1)
+		return FALSE;
+
+	adj = gtk_layout_get_hadjustment (GTK_LAYOUT (GNOME_CANVAS_ITEM (reflow)->canvas));
 	value = adj->value;
 
 	min_value = reflow->items[row]->x2 - adj->page_size;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]