[evolution-patches] issue with refreshing folder in folder view



Hi,
currently a mail folder is refreshed in the folder-view implementation
of method "set_folder", leading to a behavior where every-time a mail is
opened in a new window the folder is refreshed.

The attached patch appropriately refreshes the mail folder in the
folder-browser implementation of the "set_folder" method. 

Thanks and Cheers,
partha

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/mail/ChangeLog,v
retrieving revision 1.3619
diff -u -p -r1.3619 ChangeLog
--- ChangeLog	13 Apr 2005 03:32:58 -0000	1.3619
+++ ChangeLog	27 Apr 2005 12:53:58 -0000
@@ -1,3 +1,10 @@
+2005-04-27  Parthasarathi Susarla <sparthasarathi novell com>
+
+	* em-folder-view.c (emfv_set_folder): remove a call to
+	  refresh folder from here
+	* em-folder-browser.c (emfb_set_folder): call 
+	  mail_refresh_folder here
+	
 2005-04-12  Not Zed  <NotZed Ximian com>
 
 	** See bug #273752
Index: em-folder-view.c
===================================================================
RCS file: /cvs/gnome/evolution/mail/em-folder-view.c,v
retrieving revision 1.114
diff -u -p -r1.114 em-folder-view.c
--- em-folder-view.c	8 Apr 2005 04:34:25 -0000	1.114
+++ em-folder-view.c	27 Apr 2005 12:53:59 -0000
@@ -591,9 +591,8 @@ emfv_set_folder(EMFolderView *emfv, Came
 
 	emfv->folder = folder;
 	if (folder) {
-		camel_object_ref(folder);
-		mail_refresh_folder(folder, NULL, NULL);
-		/* We need to set this up to get the right view options for the message-list, even if we're not showing it */
+		/* We need to set this up to get the right view options for the message-list, 
+		 * even if we're not showing it */
 		emfv_setup_view_instance(emfv);
 	}
 	
Index: em-folder-browser.c
===================================================================
RCS file: /cvs/gnome/evolution/mail/em-folder-browser.c,v
retrieving revision 1.59
diff -u -p -r1.59 em-folder-browser.c
--- em-folder-browser.c	28 Feb 2005 04:31:50 -0000	1.59
+++ em-folder-browser.c	27 Apr 2005 12:53:59 -0000
@@ -940,6 +940,9 @@ emfb_set_folder(EMFolderView *emfv, Came
 		char *sstate;
 		int state;
 		GConfClient *gconf = mail_config_get_gconf_client();
+		
+		camel_object_ref(folder);
+		mail_refresh_folder(folder, NULL, NULL);
 
 		emfb->priv->folder_changed_id = camel_object_hook_event(folder, "folder_changed",
 									(CamelObjectEventHookFunc)emfb_folder_changed, emfb);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]