[evolution-patches] Re: *NEW* Patch for #300968 Updated

[Mengjie Yu <Meng-Jie Yu Sun COM>]

Patch committed into CVS Head.

Thanks for the review.

Yours,
Mengjie

On Thu, 2005-04-21 at 13:45 -0500, Hans Petter Jansson wrote:
> On Thu, 2005-04-21 at 18:27 +0800, Mengjie Yu wrote:
> > Dear hpj,
> > 
> > Here is the updated patch for #300968 which had been edited according to your proposal.
> > 
> > the related URL is:
> > http://bugzilla.gnome.org/show_bug.cgi?id=300968
> > The patch for this bug is also available on the above URL.
> > 
> > It is about addressbook part.
> > 
> > Will you please help me to review it?
> 
> Looks good, but it would look slightly better if the 'return FALSE;' was
> not on the else branch, but instead terminated the function on its own.
> I.e.
> 
> if (GTK_WIDGET_CLASS (parent_class)->focus_in_event)
>         return GTK_WIDGET_CLASS (parent_class)->focus_in_event (widget, event);
> 
> return FALSE;
>