Re: [evolution-patches] Use a static POA in ebook
- From: Not Zed <notzed ximian com>
- To: Ross Burton <ross burtonini com>
- Cc: Evolution Patches <evolution-patches lists ximian com>
- Subject: Re: [evolution-patches] Use a static POA in ebook
- Date: Fri, 22 Apr 2005 10:59:49 +0800
Is this stuff ever called from multiple threads? If so, this could end up with more than one being created (i guess not a major issue, but still not correct ...).
On Tue, 2005-04-19 at 15:46 +0100, Ross Burton wrote:
Hi,
Whilst playing with libebook I noticed that the Bonobo POAs are being
newly created for every EBookListener and EBookViewListener created.
Originally I thought that Bonobo should be freeing these as they were
leaking, but it turns out that this is a libebook bug: POAs should be
long-lived.
This patch makes the POAs static in the _new methods, so they are only
created once. Michael Meeks says this will probably improve performance
too, as multiple POAs is a bad thing.
If this gets commit approval I'll be good and make a changelog entry
too, honest.
Ross
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]