[evolution-patches] Re: Patch to remove unneeded copy in ebook

[Ross Burton <ross burtonini com>]

On Thu, 2005-04-21 at 10:29 +0100, Ross Burton wrote:
> In libedata-book/e-data-book-factory.c, in the getBook implementation,
> the BookListener is copied, but the copy is never used.  The attached
> patch removes the copy.

This time I'll attach it.   Who put the Send button right next to the
Attach button?

Ross

Index: addressbook/libedata-book/e-data-book-factory.c
===================================================================
RCS file: /cvs/gnome/evolution-data-server/addressbook/libedata-book/e-data-book-factory.c,v
retrieving revision 1.8
diff -u -r1.8 e-data-book-factory.c
--- addressbook/libedata-book/e-data-book-factory.c	15 Mar 2005 18:42:51 -0000	1.8
+++ addressbook/libedata-book/e-data-book-factory.c	21 Apr 2005 09:27:13 -0000
@@ -348,10 +348,6 @@
 	g_free (uri);
 
 	if (backend) {
-		GNOME_Evolution_Addressbook_BookListener listener_copy;
-
-		listener_copy = bonobo_object_dup_ref (listener, NULL);
-
 		g_mutex_unlock (factory->priv->map_mutex);
 
 		book = e_data_book_new (backend, source, listener);