[evolution-patches] Re: Patch for #300954 (gnome bugzilla bugID)

[Hans Petter Jansson <hpj ximian com>]

On Mon, 2005-04-18 at 00:11 +0800, Mengjie Yu wrote:
> Dear hpj,
> 
> Here is the new patch for #300954.
> the related URL is:
> http://bugzilla.gnome.org/show_bug.cgi?id=300954
> The patch for this bug is also available on the above URL.
> 
> It is about gal part.

Please remove the blank line before the declaration of reflow. Also,
when you add an idle callback like this, you must store the source ID in
your object, so if the object is destroyed before the callback is fired,
it can be disconnected. Otherwise, this would lead to a crash.

Additionally, you shouldn't add another idle callback if you already
have one pending. This can be avoided easily when you're storing the
source ID.

Please correct these issues and resend.

-- 
Hans Petter Jansson <hpj novell com>