Re: [evolution-patches] Fix for the bug #274409 [calendar]

[Rodrigo Moya <rodrigo novell com>]

On Thu, 2005-04-14 at 12:20 +0530, chenthill wrote:
> Attached the modified patch. Added a static mutex lock. The timeout
> function is called only for the calendar backend. But initially in the
> open method get_deltas would be called for both the backends, so the
> static mutex lock will prevent both the backends accessing the
> get_deltas at the same time. 
> 
looks good, except for this:

> +static gboolean
> +get_deltas_timeout (gpointer cbgw)
> +{
> +       GThread *thread;
> +       GError *error = NULL;
> +
> +       if (!cbgw)
> +               return FALSE;
> +
> +       thread = g_thread_create ((GThreadFunc) get_deltas, cbgw,
> FALSE, &error);
> +       if (!thread) {
> +               g_warning (G_STRLOC ": %s", error->message);
> +               g_error_free (error);
> +               
> +               return FALSE;

if you return FALSE, the get_deltas_timeout won't be called anymore.
-- 
Rodrigo Moya <rodrigo novell com>