[evolution-patches] Re: (groupwise)fix for bug 72302 - deleted emails not syncing up

[Harish Krishnaswamy <kharish novell com>]

hi,

  The patch looks fine. You may want to look at the following points
before committing, though. 
>        status = e_gw_connection_get_quick_messages (cnc, container_id,
> "id",
> +                               &t_str, "All", NULL, NULL, -1,
> &slist) ;

* slist and its contents are being leaked here.

* You are converting slist from a GSList to GList while passing it to
your internal function - gw_update_all_items. I think you can avoid this
by using GSList as it is. I do not see what we may gain from this
conversion.

* The comment  appears to be wrong. 
> /*item_list : List of ids from the server*/
item_list stores the ids in the summary. temp_list stores the ids from
the summary.

-Harish