Re: [evolution-patches] [PATCH] prevent evolution from crashing if new-mail-notification is enabled but D-BUS session daemon is not running

[Not Zed <notzed ximian com>]

On Wed, 2005-04-06 at 21:56 +0200, Timo Hoenig wrote:
> Hi,
>
> On Wed, 2005-04-06 at 12:20 -0400, JP Rosevear wrote: 
> > On Wed, 2005-04-06 at 15:25 +0200, Timo Hoenig wrote:
> > > Hi,
> > > 
> > > Evolution crashes if the new-mail-notification plugin is enabled and
> > > gconf key is set to true but the D-BUS session daemon is not running.
> > > 
> > > Attached is a fix which adds the appropriate checks.
> > > 
> > > Additionally, the plugin now refuses to load once it is enabled but the
> > > address of the D-BUS session daemon can not be determined.
> > 
> > Is there no DBUS api for checking if its running rather than peeking at
> > an environment variable?
>
> Actually there is, I have updated the patch.  Nevertheless, D-BUS uses
> getenv(3) to find the address of the session bus, too.  But using the
> API will hopefully give us some more safety for the future.  At least if
> DBUS_SESSION_BUS_ADDRESS would happen to change.

Where exactly is it crashing anyway?  Is it the plugin dereferncing a null pointer, or is it somewhere inside of the dbus library?

It seems rather redundant to have to have all these extra checks, if it is just a code bug.


> CC'ing Miguel since I have touched his code (renamed the variable for
> the D-BUS connection from 'bus' to 'connection'). 

Why?  This change seems totally redundant.  Its just more typing too.

> > -JP
>
> Thanks,
>
>    Timo