Re: [evolution-patches] ssl/tls patch (bug #65714)



Ah, good catch. silly me.

committed

Jeff

On Mon, 2004-09-27 at 09:20 +0800, Not Zed wrote:
> 
> The patch attached applied after the original one, should fix the
> problem.
> 
> On Mon, 2004-09-27 at 09:08 +0800, Not Zed wrote:
> > 
> > Umm, i should've tested this more, too busy on friday.  It breaks at
> > least pop3s connections.  I thought mail was down all weekend but it
> > was just this patch still in my build.  Blah.
> > 
> > On Fri, 2004-09-24 at 13:09 +0800, Not Zed wrote:
> > > 
> > > looks ok to me, apart from perhaps the string changes for the
> > > exceptions, e.g.
> > > 
> > > _("Failed to connect to POP server %s in secure mode: STLS not
> > > supported"),
> > > 
> > > may as well leave the old one:
> > > 
> > > camel_exception_setv (ex, CAMEL_EXCEPTION_SYSTEM,
> > > -       _("Failed to connect to POP server %s in secure mode: %
> > > s"),
> > > -       service->url->host, _("SSL/TLS extension not
> > > supported."));
> > > 
> > > 
> > > i'm not that hot on the popup menu names 'SSL encryption', 'TLS
> > > encryption', etc but i can't really suggest an alternative.
> > > 
> > > The code is fine though.
> 
> -- 
> 
> Michael Zucchi <notzed ximian com>
> "born to die, live to work, it's
> all downhill from here"
> Novell's Evolution and Free
> Software Developer
-- 
Jeffrey Stedfast
Evolution Hacker - Novell, Inc.
fejj ximian com  - www.novell.com

Attachment: smime.p7s
Description: S/MIME cryptographic signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]