Re: [evolution-patches] 66344 Crash adding Start Date Field to tasks

[JP Rosevear <jpr novell com>]

On Wed, 2004-09-22 at 23:16 +0200, Rodrigo Moya wrote:
> On Wed, 2004-09-22 at 14:43 -0400, JP Rosevear wrote:
> > With a bogus start date, we would crash because struct tm was empty
> > during strftime.  Fixed end date, completed and due while I was at it
> > too.
> > 
> looks good

Realized the patch I sent didn't include all the changes, new patch
attached.

-JP
-- 
JP Rosevear <jpr novell com>
Novell, Inc.

Index: gui/e-cal-model-tasks.c
===================================================================
RCS file: /cvs/gnome/evolution/calendar/gui/e-cal-model-tasks.c,v
retrieving revision 1.24.6.2
diff -u -p -r1.24.6.2 e-cal-model-tasks.c
--- gui/e-cal-model-tasks.c	21 Sep 2004 16:09:05 -0000	1.24.6.2
+++ gui/e-cal-model-tasks.c	23 Sep 2004 13:07:44 -0000
@@ -242,7 +242,7 @@ get_completed (ECalModelComponent *comp_
 			return NULL;
 
 		tt_completed = icalproperty_get_completed (prop);
-		if (!icaltime_is_valid_time (tt_completed))
+		if (!icaltime_is_valid_time (tt_completed) || icaltime_is_null_time (tt_completed))
 			return NULL;
 
 		comp_data->completed = g_new0 (ECellDateEditValue, 1);
@@ -272,7 +272,7 @@ get_due (ECalModelComponent *comp_data)
 			return NULL;
 
 		tt_due = icalproperty_get_due (prop);
-		if (!icaltime_is_valid_time (tt_due))
+		if (!icaltime_is_valid_time (tt_due) || icaltime_is_null_time (tt_due))
 			return NULL;
 
 		comp_data->due = g_new0 (ECellDateEditValue, 1);