[evolution-patches] Re: Outstanding Evolution 2.0.0 Patches

[JP Rosevear <jpr novell com>]

On Sun, 2004-09-12 at 16:51 +0200, Murray Cumming wrote:
> On Fri, 2004-09-10 at 14:04 -0400, JP Rosevear wrote:
> > This is a bit tricky to track because the evolution-patches mailing list
> > has had intermittent problems, but as far as I know we have the
> > following patches waiting on approval from the release team
> > 
> > 65172/63170/61140
> > -dobey's documentation patch covers these plus updates all the docs, it
> > touch the code in 1 or 2 spots to load the correct doc book file,
> > otherwise it makes no code changes
> > -been approved by me with one minor change
> 
> I didn't really get satisfactory answers to my questions about this. It
> seems very late to be integrating large structural documentation changes
> at this point, if that's what it is. But if you think it's minor and you
> approve it, then here's 1 of 2 r-t approvals, because I know you worry
> enough.

I believe the structural changes are only file related (ie we don't have
the external entities we once had, they have been collapsed into a
single file).  The latest had to do with co-ordinating with the Novell
Documentation team, and that took longer than expecting (the process
being new to us this week).  I'm a little unclear why its such an issue
actually, because as I understand it, except for the two lines this
touches in the code this isn't really supposed to need r-t approval
(since there is no doc freeze).

> > 17338
> > -not strictly necessary for 2.0.0 but really good to have
> > -peer approved
> > -needs r-t and i18n approval
> 
> This has had i18n approval from Christian Rose, and the r-t defer to the
> i18n team for string freeze breaks. Please go ahead.

Done.

> > 57443
> > -second version of this peer approved
> > -this gets us back to the 1.4 behaviour
> 
> This has been approved by the r-t.

Ok, rodrigo should commit this shortly.

> > 64974
> > -this is a ui breakage but a rather bad regression
> > -waiting for r-t approval and peer review
> 
> I see lots of discussion that's been CCed to us, but I don't know
> exactly what the r-t being asked to approve.

The basic idea of the patch is to give a means to the user to choose
either a file or directory with GtkFileChooser (while the file chooser
is visible, the was allowed in GtkFileSel).  The first patch fejj sent
apparently has an issue and hence the confusion (found during peer
review), we should have an updated patch shortly.

-JP
-- 
JP Rosevear <jpr novell com>
Novell, Inc.