Re: [evolution-patches] 17338 - Translator Credits in About Box

[Christian Rose <menthos gnome org>]

ons 2004-09-08 klockan 19.08 skrev JP Rosevear:
> On Tue, 2004-09-07 at 15:37 -0400, Dan Winship wrote:
> > On Tue, 2004-09-07 at 15:01 -0400, JP Rosevear wrote:
> > > Also, the utf8 comment seems odd, could this be a pre 1.4 hold over? I
> > > didn't escape some new people and that seemed to work fine.
> > 
> > \x is greedy, so if you say "Garc\xC3\xADa", it's parsed as "Garc\xC3"
> > plus a "warning: hex escape sequence out of range". It's only a problem
> > for \x escapes followed by a valid hex digit as the next character
> > though, which is probably why you didn't have any problems with it.
> > 
> > > +       "Danilo Šegan",
> > 
> > You should either use \x escapes there, or use actual UTF-8 chars
> > consistently through the whole array.
> 
> Attached patch breaks string freeze, in the spot to grab translator
> credits, I was told in #gnome-i18n this was the way to do it.

Please use a hyphen instead of an underscore, as Åsmund explained: use
"translator-credits" instead of "translator_credits". Also, an
explanatory translator comment that explained how this string is used
would be extremely helpful.

http://developer.gnome.org/doc/tutorials/gnome-i18n/developer.html#credits
http://developer.gnome.org/doc/tutorials/gnome-i18n/developer.html#use-comments

As far as string freeze goes, I think this change is appreciated by
translators, and not considered harmful. It has my approval, if you also
notify when this change has landed in CVS.


Christian