Re: [evolution-patches] Fix for bug #63513 [calendar]

[Rodrigo Moya <rodrigo novell com>]

On Sun, 2004-09-05 at 20:26 +0530, chenthill wrote:
> Hi,
>    We should do case insensitive comaprison between the email ids.
> 
this patch has been committed to HEAD without approval, or are there
still problems in the mailing list and the approval didn't get through?

> @@ -685,13 +685,19 @@ e_gw_connection_send_appointment (EGwCon
>                 /* get attendee here and add the list along. */
>                 if (e_cal_component_has_attendees (comp)) {
>                         GSList *attendee_list, *l;
> +                       char *email_id;
>                         ECalComponentAttendee  *attendee = NULL, *tmp;
>  
>                         
>                         e_cal_component_get_attendee_list (comp,
> &attendee_list);
>                         for (l = attendee_list; l ; l = g_slist_next
> (l)) {
>                                 tmp = (ECalComponentAttendee *) (l-
> >data);
> -                               if (!strcmp (tmp->value + 7,
> e_gw_connection_get_user_email (cnc))) {
> +                               email_id = tmp->value;
> +                               
> +                       if (!g_strncasecmp (email_id, "mailto:";, 7))
> +                               email_id += 7;
> +                       
> +                       if (!strcasecmp (email_id,
> e_gw_connection_get_user_email (cnc))) {
> 
I think email_id should be initialized to NULL at least, since there
might be cases where it doesn't get any value, arent there? ie, if the
email is not on the list of attendees?

Then, take into account comment from Michael (use ascii_strcasecmp
instead to avoid localisation effects)
-- 
Rodrigo Moya <rodrigo novell com>