the mail-config.glade (the part that wasn't accepted) part is not a code change and so I wouldn't have thought it needed review. also, it was mailed anyway to release-team@ last week and it still hasn't gotten a single reply. if release-team truly feel that this is a bad patch, couldn't it at least get a review? I can't see how anyone could actually reject it seeing as how it's the ONLY possible solution and has NO RISK of causing more bugs. Jeff On Tue, 2004-09-07 at 19:03 +0200, Frederic Crozat wrote: > (resent, I use the wrong evolution-patches address). > > Le mardi 07 septembre 2004 à 10:22 -0400, Gnome CVS User a écrit : > > Modified files: > > mail : Tag: gnome-2-8 ChangeLog em-format.c em-utils.c > > mail-config.glade > > > > Log message: > > 2004-09-03 Jeffrey Stedfast <fejj novell com> > > > > * mail-config.glade: Revert the use of gtkfilechooser for Path > > selection because otherwise users won't be able to select > > directory pathnames. Fixes bug #64974 [http://bugzilla.gnome.org/show_bug.cgi?id=64974]. > > > > 2004-09-01 Jeffrey Stedfast <fejj novell com> > > > > Fix for bug #63377 [http://bugzilla.gnome.org/show_bug.cgi?id=63377] and prevention of similar cases. > > > > * em-format.c (emf_finalise): Free the default_charset. > > (emf_format_clone): Clone the default_charset - this prevents the > > particular crash described in bug #63377 [http://bugzilla.gnome.org/show_bug.cgi?id=63377]. > > > > * em-utils.c (em_utils_message_to_html): If source is NULL, set > > our own default charset (from the user's gconf key) on the > > formatter to make sure there's always a source charset for > > conversion to UTF-8. > > The following commit has NOT been approved by release-team. > > Please revert. > -- Jeffrey Stedfast Evolution Hacker - Novell, Inc. fejj ximian com - www.novell.com
Attachment:
smime.p7s
Description: S/MIME cryptographic signature