Re: [evolution-patches] patch for ldap addr book backend

[Chris Toshok <toshok ximian com>]

On Tue, 2004-09-07 at 10:10 +0530, Sivaiah Nallagatla wrote:
> oops, attached 
> 
> Thanks,
> Siva
> On Mon, 2004-09-06 at 16:21 -0500, Hans Petter Jansson wrote:
> > On Mon, 2004-09-06 at 20:05 +0530, Sivaiah Nallagatla wrote:
> > 
> > > Attached patch fixes some of the  issues mentined in #59582
> > > (1) Calendar/Free busy uri fileds are disbled in ui eventhough backend
> > > supports them - reason is wrong ldap attribute names in code
> > > (2) Adds email field to list of supported fields, also uses
> > > e_contact_filed_name to get field names insted of hard coding them. This
> > > is better since cahnging names in e-contact.c can break things in the
> > > backend, though it has lsight overhaed of function calls 
> > > (3) Corrects Anniversary date showing incorrectly problem - a small
> > > probelm in parameter passing
> > 
> > It's missing the patch.
> > 


> 
> Index: backends/ldap/e-book-backend-ldap.c
> ===================================================================
> RCS file: /cvs/gnome/evolution-data-
> server/addressbook/backends/ldap/e-book-backend-ldap.c,v
> retrieving revision 1.30
> diff -u -r1.30 e-book-backend-ldap.c
> --- backends/ldap/e-book-backend-ldap.c 21 Aug 2004 21:52:39 -
> 0000      1.30
> +++ backends/ldap/e-book-backend-ldap.c 6 Sep 2004 14:22:01 -0000
> @@ -280,8 +280,8 @@
>  
>         E_COMPLEX_PROP (E_CONTACT_CATEGORY_LIST,  "category",
> category_populate, category_ber, category_compare),
>  
> -       STRING_PROP (E_CONTACT_CALENDAR_URI,   "calCalURI"),
> -       STRING_PROP (E_CONTACT_FREEBUSY_URL,   "calFBURL"),
> +       STRING_PROP (E_CONTACT_CALENDAR_URI,   "calendarURI"),
> +       STRING_PROP (E_CONTACT_FREEBUSY_URL,   "freeBusyURI"),
>         STRING_PROP (E_CONTACT_ICS_CALENDAR,   "icsCalendar"),
> 

This is wrong - evolutionperson.schema lists those attributes as
deprecated for a reason.  There's an RFC (2739) that defines the
attributes calCalURI and calFBURL.

Rest of the patch looks fine.

Chris