patches look good On Fri, 2004-09-03 at 12:31 +0800, Not Zed wrote: > > Hi guys, > > Another mailer crasher fix. > > This is in two parts, one is low-risk but has unpleasant user side- > effects, the other part is higher risk and may need more testing first > but fixes the side-effects. > > Making the dialogue modal fixes the nasty re-entrancy we can get in > this non-reentrant synchronous method - i tried various ways around > doing this but it got too complex, and as far as i can tell could > never work. However when you connect to a host using SSL, > cancellation is a noop, so it can take 4 minutes to time out. 4 > minutes in which time you can't do anything else. e.g. if the user > put in the wrong hostname they're kind of stuck. > > Which is where the second patch comes in, it enables cancellation for > a SSL connect. Its only high risk in that this code has forever > caused lots of issues, so i'm not sure if the fix breaks it in subtle > ways. I did some testing and it appears to work though - "i don't see > why it shouldn't work". I guess it can wait till 2.0.1 if need be. > > Michael > > -- > > Michael Zucchi <notzed ximian com> > "born to die, live to work, it's > all downhill from here" > Novell's Evolution and Free > Software Developer -- Jeffrey Stedfast Evolution Hacker - Novell, Inc. fejj ximian com - www.novell.com
Attachment:
smime.p7s
Description: S/MIME cryptographic signature