[evolution-patches] 64420, evolution crash importing certificate

[Not Zed <notzed ximian com>]

Pretty obvious/straightforward fix, use of uninitialised data.

http://bugzilla.ximian.com/show_bug.cgi?id=64420

--

Michael Zucchi <notzed ximian com> "born to die, live to work, it's all downhill from here" Novell's Evolution and Free Software Developer

Index: smime/ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/smime/ChangeLog,v
retrieving revision 1.41
diff -u -3 -r1.41 ChangeLog
--- smime/ChangeLog	18 Aug 2004 02:28:55 -0000	1.41
+++ smime/ChangeLog	3 Sep 2004 04:48:41 -0000
@@ -1,3 +1,10 @@
+2004-09-03  Not Zed  <NotZed Ximian com>
+
+	** See bug #64420.
+
+	* lib/e-pkcs12.c (prompt_for_password): set the outptr after we've
+	actually got a pointer for it allocated.
+
 2004-08-16  Not Zed  <NotZed Ximian com>
 
 	** See bug #62963.
Index: smime/lib/e-pkcs12.c
===================================================================
RCS file: /cvs/gnome/evolution/smime/lib/e-pkcs12.c,v
retrieving revision 1.6
diff -u -3 -r1.6 e-pkcs12.c
--- smime/lib/e-pkcs12.c	12 Aug 2004 06:55:36 -0000	1.6
+++ smime/lib/e-pkcs12.c	3 Sep 2004 04:48:42 -0000
@@ -224,11 +224,12 @@
 	if (passwd) {
 		size_t len = strlen (passwd);
 		const char *inptr = passwd;
-		char *outptr = pwd->data;
+		char *outptr;
 		gunichar2 c;
 		
 		SECITEM_AllocItem(NULL, pwd, sizeof (gunichar2) * (len + 1));
 		
+		outptr =  pwd->data;
 		while (inptr && (c = (gunichar2) (g_utf8_get_char (inptr) & 0xffff))) {
 			inptr = g_utf8_next_char (inptr);
 			c = GUINT16_TO_BE (c);