Re: [evolution-patches] [bug #65211] gnome-spell not localized in Solaris/Linux.

[Not Zed <notzed ximian com>]

Wont this just fuck-up the rest of evolution's localisation?

Once you set the text domain it remains static for the rest of the life of the application.

If glade doesn't handle i18n for its own strings, its a bug in glade.

On Thu, 2004-09-02 at 19:53 +0800, Yong.Sun wrote:
> Hi, guys,
>
> Please help review this little patch:
>
> Description of Problem: 
> In Solaris, gnome spellchecker entries preference dialog are not localized.
>
> Steps to reproduce the problem:
> 1. Launch evolution in non-C locales,
> 2. Open the setup dialog, select "Composer Preferences" item, then the "Spell Checking" tab.
> 3. You could find the 3 entries are not localized.
>
> Actual Results:
>   You could find the 3 entries are not localized.
>
> Expected Results:
>   These 3 entries should be localized.
>
> How often does this happen? 
>   Every time.
>
>
> --
> Yong Sun <Yong Sun Sun COM>
> Sun (China) ERI -- BAGC
>
>
>
> Index: control.c
> ===================================================================
> RCS file: /cvs/gnome/gnome-spell/gnome-spell/control.c,v
> retrieving revision 1.17
> diff -u -p -r1.17 control.c
> --- control.c   25 Aug 2004 09:47:58 -0000      1.17
> +++ control.c   2 Sep 2004 11:54:42 -0000
> @@ -408,7 +408,10 @@ gnome_spell_control_new ()
>         GtkWidget *table;
>         GladeXML *xml;
>
> -       xml = glade_xml_new (GLADE_DATADIR "/spell-checker.glade", "simple_control", NULL);
> +       bindtextdomain (GETTEXT_PACKAGE, GNOMELOCALEDIR);
> +       bind_textdomain_codeset(GETTEXT_PACKAGE, "UTF-8");
> +
> +       xml = glade_xml_new (GLADE_DATADIR "/spell-checker.glade", "simple_control", GETTEXT_PACKAGE);
>         if (!xml)
>                 g_error (_("Could not load glade file."));
>         table = glade_xml_get_widget (xml, "simple_control");
> Index: dictionary.c
> ===================================================================
> RCS file: /cvs/gnome/gnome-spell/gnome-spell/dictionary.c,v
> retrieving revision 1.37
> diff -u -p -r1.37 dictionary.c
> --- dictionary.c        27 Feb 2004 11:04:03 -0000      1.37
> +++ dictionary.c        2 Sep 2004 11:54:45 -0000
> @@ -595,5 +595,7 @@ BONOBO_TYPE_FUNC_FULL (
>  BonoboObject *
>  gnome_spell_dictionary_new (void)
>  {
> +       bindtextdomain (GETTEXT_PACKAGE, GNOMELOCALEDIR);
> +       bind_textdomain_codeset(GETTEXT_PACKAGE, "UTF-8");
>         return g_object_new (GNOME_SPELL_DICTIONARY_TYPE, NULL);
>  }
>
>
>
>
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches