Re: [evolution-patches] #63731 - You made Japanese input worse than ever

[Nakai <ynakai redhat com>]

On Tue, 31 Aug 2004 16:05:32 +0800
Not Zed <notzed ximian com> wrote:

> 
> Must be some serious performance issues with the im stuff.  But anyway,
> a comment below.
> 
> BTW nobody knows how EText works, its left over from the previous
> maintainer who dropped it in our lap, so basically if the patch works,
> its probably ok with us.  Suresh does this look ok to you?

Suresh wrote another comment. So if it gets to be good through his
review, that's fine for you?

> This patch will also need ChangeLog entries but assuming it does what it
> needs to do and the F10 thing is sorted, it looks reasonable to me.

> > - Move gtk_im_context_filter_keypress() funcs to
> >   GDK_KEY_PRESS section. Because the keypress func
> >   doesn't make sense in GDK_KEY_RELEASE section.
> 
> This is done before the shift-F10 keypress check, should this be the
> case?  Will it interfere with accessibility?

Input method must recieve any key events before any other key handling by application
or toolkits. And if the input method doesn't need Shift+F10, it must not handle it and
must pass to the application.
http://bugzilla.gnome.org/show_bug.cgi?id=90082

So that's a sane change.
--
Nakai