Re: [evolution-patches] [Patch] EDS crash when committing twice a contact

[Diego Gonzalez <diego pemas net>]

On Thu, 2004-10-28 at 00:22 -0500, Hans Petter Jansson wrote:
> On Tue, 2004-10-19 at 23:39 +0200, Diego Gonzalez wrote:
> > try this:
> > 
> > ...
> > e_book_commit_contact (book, contact, &error);
> > ...
> > e_contact_set (contact, E_CONTACT_EMAIL_1, "my email com");
> > ...
> > e_book_commit_contact (book, contact, &error);
> > 
> > the result will be that the EDS will crash.
> > 
> > This crash is due to the uid of the contact being NULL in the second call,
> > the server shouldn't crash even in this case (the patch fixes this case).
> > 
> > The root case of the problem is that in the do_commit_contact call in the
> > client side the UID is set to null with this call:
> > 
> > e_contact_set (contact, E_CONTACT_UID, our_op->id);
> > 
> > this is done supposedly to make the last operation (commit) complete and
> > thus emulate a sync behaviour, but this also caused the UID of the contact
> > to be set to NULL. (There is also a fix for this bug in the patch).
> > 
> > I hope the fix for this case is the rigth one, it seems to work without a
> > glitch.
> > 
> > PS: I'm not on the lists, please CC me if i have to change anything
> 
> Patch approved. Sorry it took so long, I needed to test it. Do you have
> commit access or should I commit it?
> 
yeah, i can commit it, thanks

-- 
Diego