[evolution-patches] 68006, mail, crash after copy link

[Not Zed <notzed ximian com>]

i think the inivisble is hanging around after the widget is destroyed.

without this, you can't paste if the window's closed, but it doesn't crash. (i think - i couldn't recreate it anyway).

--

Michael Zucchi <notzed ximian com> "born to die, live to work, it's all downhill from here" Novell's Evolution and Free Software Developer

Index: mail/ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/mail/ChangeLog,v
retrieving revision 1.3444.2.22
diff -u -3 -r1.3444.2.22 ChangeLog
--- mail/ChangeLog	12 Oct 2004 02:33:06 -0000	1.3444.2.22
+++ mail/ChangeLog	18 Oct 2004 06:38:22 -0000
@@ -1,3 +1,10 @@
+2004-10-18  Not Zed  <NotZed Ximian com>
+
+	** See bug #68006.
+
+	* em-folder-view.c (emfv_init): dont ref/sink the invisible.
+	(emfv_destroy): just destroy it here.
+
 2004-10-11  Not Zed  <NotZed Ximian com>
 
 	** See bug #67408.
Index: mail/em-folder-view.c
===================================================================
RCS file: /cvs/gnome/evolution/mail/em-folder-view.c,v
retrieving revision 1.85.6.1
diff -u -3 -r1.85.6.1 em-folder-view.c
--- mail/em-folder-view.c	12 Oct 2004 02:33:06 -0000	1.85.6.1
+++ mail/em-folder-view.c	18 Oct 2004 06:38:23 -0000
@@ -187,8 +187,6 @@
 	g_signal_connect (emfv->preview, "on_url", G_CALLBACK (emfv_on_url_cb), emfv);
 
 	p->invisible = gtk_invisible_new();
-	g_object_ref(p->invisible);
-	gtk_object_sink((GtkObject *)p->invisible);
 	g_signal_connect(p->invisible, "selection_get", G_CALLBACK(emfv_selection_get), emfv);
 	g_signal_connect(p->invisible, "selection_clear_event", G_CALLBACK(emfv_selection_clear_event), emfv);
 	gtk_selection_add_target(p->invisible, GDK_SELECTION_PRIMARY, GDK_SELECTION_TYPE_STRING, 0);
@@ -249,7 +247,7 @@
 	}
 
 	if (p->invisible) {
-		g_object_unref(p->invisible);
+		gtk_object_destroy(p->invisible);
 		p->invisible = NULL;
 	}