Re: [evolution-patches] calendar main menu patch




Well i'm just committing this.  It needs to go in anyway and the focus issues affect the existing code anyway.  I guess things can be sorted out as they become issues.

On Thu, 2004-10-14 at 12:28 +0800, Not Zed wrote:

Ok this might need some feedback before I commit it.

I wasn't sure where to hook in updating the context, and i haven't had a chance to test any of it yet, but i'm pretty sure what i've done will be adequate.  To make it consistent with the popup stuff I didn't do 100% identical logic with some of it - that should probably be verified/checked to make sense.

To handle both view areas I have two separate 'menu's to hook into, one is the taskpad the other is the main calendar view.  They both activate together but update based on the same logic the calendar does.

But the big problem stems from my last message to evolution-hackers about knowing the current state, the focus tracking (in calendar-commands.c) never switches to the taskpad, even when it has the focus.  In the work-week view, when you click on a different appointment it never gets a "selection changed" event either, leaving the target pointing at the first thing you clicked on - until you change focus and then it moves it.

Most of this isn't an issue with the calendar code since it just queries the current state but the plugin stuff needs to snapshot the state when it changes instead.

--
Michael Zucchi <notzed ximian com>
"born to die, live to work, it's all downhill from here"
Novell's Evolution and Free Software Developer


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]