Re: [evolution-patches] calendar properties window plugin hooks

[Not Zed <notzed ximian com>]

The ESource in the target should be modified instantly as the widgets change.  This is required for a couple of reasons:
1. Communicate the changed state to any other interested widgets, which may be supplied by plugins
2. Lets the gui know when things have changed, so it can only enable the "ok" button if the data validates.

It also simplifies 'commit' since you just copy/install that source.  Obviously the ESource in the target should be a working-copy and not the actual ESource.  And clearly point 1 is the vital one.

For the plugin it needs to ref the source and keep it around for the widget modified callbacks.  Also note that this should mean you don't need to keep any globals to access them since the data will just be on the source already.  It doesn't need a commit method really since all of its state is stored in the source which will be committed by the master programme.

I suspect as the calendar naming conventions seem to be e_cal, that would make sense more than ec_, esp since the filename was changed to e-cal-.

You should probably also do page_check(xx, NULL) since you want all values checked - there might be more pages.

But those are minor points apart from the instant-change-to-source thing.

I'm not sure who needs to own the copyrights if the code is going to be in the main tree, Novell may want to, even for plugins.

On Thu, 2004-10-14 at 15:27 -0600, David Trowbridge wrote:
> Here is my first attempt at adding config hooks for the calendar
> properties window.
>
> Note that at this time, field verification isn't enabled, since I wasn't
> sure what people wanted for it.
>
> It requires a plugin to be installed for webcal properties to function
> correctly - i've added a plugins/ directory to the evolution root (as
> per some discussion on irc a week or so back). This will probably mean
> changing EPlugin to load plugins from both the system directory and the
> user EVOLUTION_PLUGIN_PATH, rather than just one or the other.
>
> -David

--

Michael Zucchi <notzed ximian com> "born to die, live to work, it's all downhill from here" Novell's Evolution and Free Software Developer