Re: [evolution-patches] Hi, JP and Rodrigo Now I have a patch in widgets directory for cvs HEAD. It fixes some a11y bugs. The patch has passed our internel review.



On Sun, 2004-10-10 at 15:31 +0800, Li Yuan wrote:
> Rodrigo Moya wrote:
> 
> >On Wed, 2004-09-29 at 21:22 +0800, Li Yuan wrote:
> >  
> >
> >> Please help me to review it. Thanks a lot.
> >>	
> >>Index: gui/e-meeting-time-sel.c
> >>===================================================================
> >>RCS file: /cvs/gnome/evolution/calendar/gui/e-meeting-time-sel.c,v
> >>retrieving revision 1.62
> >>diff -u -r1.62 e-meeting-time-sel.c
> >>--- gui/e-meeting-time-sel.c	22 Jul 2004 18:11:24 -0000	1.62
> >>+++ gui/e-meeting-time-sel.c	29 Sep 2004 13:17:52 -0000
> >>@@ -277,6 +277,7 @@
> >> 	guchar stipple_bits[] = {
> >> 		0x01, 0x02, 0x04, 0x08, 0x10, 0x20, 0x40, 0x80,
> >> 	};
> >>+	AtkObject *a11yLabel, *a11yDateEdit;
> >> 
> >>    
> >>
> >we never use studlyCaps for variable names.
> >
> >the rest looks ok
> >  
> >
> 
> Hi,
> 
> i modified the variable names.
> and there is also some change in gui/dialogs/task-page.glade, i add a11y 
> names to task description and categories.
> is it ok now?
>
looks good to me
-- 
Rodrigo Moya <rodrigo novell com>




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]